components/payments/core/journey_logger.cc - Issue 2870153002: [Payments] Record navigations that close the Payment Request as aborts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/payments/core/journey_logger.cc

Issue 2870153002: [Payments] Record navigations that close the Payment Request as aborts. (Closed)

Patch Set: Addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/payments/core/journey_logger.cc

diff --git a/components/payments/core/journey_logger.cc b/components/payments/core/journey_logger.cc

index 11665b770cd09012252f156e45b1e64bf866dc45..aeae9aa0652bf7083c6e76c8c5f482a4c06a61d4 100644

--- a/components/payments/core/journey_logger.cc

+++ b/components/payments/core/journey_logger.cc

@@ -72,7 +72,10 @@ JourneyLogger::JourneyLogger(bool is_incognito,

url_(url),

ukm_service_(ukm_service) {}

-JourneyLogger::~JourneyLogger() {}

+JourneyLogger::~JourneyLogger() {

+ if (was_show_called_)

+ DCHECK(has_recorded_);

void JourneyLogger::IncrementSelectionAdds(Section section) {

DCHECK_LT(section, SECTION_MAX);