Issue 287015: GTK: properly resize bookmark bar when going from attached to detached on NTP...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287015: GTK: properly resize bookmark bar when going from attached to detached on NTP... (Closed)

Created:
11 years, 2 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: properly resize bookmark bar when going from attached to detached on NTP fullscreen. BUG=24463 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29353

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/gtk/bookmark_bar_gtk.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 2 months ago (2009-10-16 23:17:49 UTC) #2

Lgtm

On Friday, October 16, 2009,  <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> GTK: properly resize bookmark bar when going from attached to detached on=
 NTP
> fullscreen.
>
> BUG=3D24463
>
>
> Please review this at http://codereview.chromium.org/287015
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  =A0M =A0 =A0 chrome/browser/gtk/bookmark_bar_gtk.cc
>
>
> Index: chrome/browser/gtk/bookmark_bar_gtk.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/gtk/bookmark_bar_gtk.cc =A0 =A0 =A0(revision 29332)
> +++ chrome/browser/gtk/bookmark_bar_gtk.cc =A0 =A0 =A0(working copy)
> @@ -343,8 +343,9 @@
> =A0#endif
>
> =A0void BookmarkBarGtk::EnterFullscreen() {
> - =A0UpdateFloatingState();
> - =A0if (!floating_)
> + =A0if (ShouldBeFloating())
> + =A0 =A0Show(false);
> + =A0else
>  =A0 =A0 gtk_widget_hide(widget());
> =A0}
>
>
>
>

Expand Messages | Collapse Messages