DescriptionDon't depend on (empty) chromeos-only display target
Otherwise, when display.dll is built in component it won't generated display.dll.lib (the import library). This is empty on non-cros.
This causes dependents to fail to link with:
FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True ash_shell_unittests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:ash_shell_unittests.exe @ash_shell_unittests.exe.rsp" 1 mt.exe rc.exe "obj\ash\ash_shell_unittests.ash_shell_unittests.exe.intermediate.manifest" obj\ash\ash_shell_unittests.ash_shell_unittests.exe.generated.manifest ..\..\build\win\compatibility.manifest
LINK : fatalerror LNK1104: cannot open file 'display.dll.lib'
This only occurs on x64 because the x86 is non-component. It didn't get caught on the waterfall because there's no clobber x64 builder yet.
R=huangs@chromium.org, wfh@chromium.org
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270825
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 4 (0 generated)
|