Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 287013005: Don't depend on (empty) chromeos-only display target (Closed)

Created:
6 years, 7 months ago by scottmg
Modified:
6 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Don't depend on (empty) chromeos-only display target Otherwise, when display.dll is built in component it won't generated display.dll.lib (the import library). This is empty on non-cros. This causes dependents to fail to link with: FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True ash_shell_unittests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:ash_shell_unittests.exe @ash_shell_unittests.exe.rsp" 1 mt.exe rc.exe "obj\ash\ash_shell_unittests.ash_shell_unittests.exe.intermediate.manifest" obj\ash\ash_shell_unittests.ash_shell_unittests.exe.generated.manifest ..\..\build\win\compatibility.manifest LINK : fatalerror LNK1104: cannot open file 'display.dll.lib' This only occurs on x64 because the x86 is non-component. It didn't get caught on the waterfall because there's no clobber x64 builder yet. R=huangs@chromium.org, wfh@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270825

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ash/ash.gyp View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
6 years, 7 months ago (2014-05-15 21:44:33 UTC) #1
huangs
lgtm
6 years, 7 months ago (2014-05-15 21:46:25 UTC) #2
Will Harris
On 2014/05/15 21:44:33, scottmg wrote: LGTM
6 years, 7 months ago (2014-05-15 21:46:53 UTC) #3
scottmg
6 years, 7 months ago (2014-05-15 21:52:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r270825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698