Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: webkit/glue/webview_impl.cc

Issue 287009: Move WebDevToolsAgent{Delegate} into the WebKit API.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webview_impl.h ('k') | webkit/tools/test_shell/mac/test_shell_webview.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webview_impl.cc
===================================================================
--- webkit/glue/webview_impl.cc (revision 29289)
+++ webkit/glue/webview_impl.cc (working copy)
@@ -80,7 +80,6 @@
#include "webkit/glue/webdevtoolsagent_impl.h"
#include "webkit/glue/webkit_glue.h"
#include "webkit/glue/webpopupmenu_impl.h"
-#include "webkit/glue/webdevtoolsagent.h"
#include "webkit/glue/webdevtoolsclient.h"
#include "webkit/glue/webview_delegate.h"
#include "webkit/glue/webview_impl.h"
@@ -99,6 +98,8 @@
using WebKit::WebCompositionCommand;
using WebKit::WebCompositionCommandConfirm;
using WebKit::WebCompositionCommandDiscard;
+using WebKit::WebDevToolsAgent;
+using WebKit::WebDevToolsAgentClient;
using WebKit::WebDragData;
using WebKit::WebDragOperation;
using WebKit::WebDragOperationCopy;
@@ -354,11 +355,10 @@
main_frame->InitMainFrame(this);
- if (delegate_) {
- WebDevToolsAgentDelegate* tools_delegate =
- delegate_->GetWebDevToolsAgentDelegate();
- if (tools_delegate)
- devtools_agent_.reset(new WebDevToolsAgentImpl(this, tools_delegate));
+ if (client()) {
+ WebDevToolsAgentClient* tools_client = client()->devToolsAgentClient();
+ if (tools_client)
+ devtools_agent_.reset(new WebDevToolsAgentImpl(this, tools_client));
}
// Restrict the access to the local file system
@@ -1665,6 +1665,10 @@
inspector_settings_ = settings;
}
+WebDevToolsAgent* WebViewImpl::devToolsAgent() {
+ return devtools_agent_.get();
+}
+
WebAccessibilityObject WebViewImpl::accessibilityObject() {
if (!main_frame())
return WebAccessibilityObject();
@@ -1751,10 +1755,6 @@
}
}
-WebDevToolsAgent* WebViewImpl::GetWebDevToolsAgent() {
- return GetWebDevToolsAgentImpl();
-}
-
WebDevToolsAgentImpl* WebViewImpl::GetWebDevToolsAgentImpl() {
return devtools_agent_.get();
}
@@ -1869,11 +1869,6 @@
ignore_input_events_ = new_value;
}
-WebCore::Node* WebViewImpl::GetNodeForWindowPos(int x, int y) {
- HitTestResult result = HitTestResultForWindowPos(IntPoint(x, y));
- return result.innerNonSharedNode();
-}
-
#if ENABLE(NOTIFICATIONS)
WebKit::NotificationPresenterImpl* WebViewImpl::GetNotificationPresenter() {
if (!notification_presenter_.isInitialized() && client())
« no previous file with comments | « webkit/glue/webview_impl.h ('k') | webkit/tools/test_shell/mac/test_shell_webview.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698