Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: webkit/glue/webdevtoolsagent_impl.h

Issue 287009: Move WebDevToolsAgent{Delegate} into the WebKit API.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webdevtoolsagent_delegate.h ('k') | webkit/glue/webdevtoolsagent_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webdevtoolsagent_impl.h
===================================================================
--- webkit/glue/webdevtoolsagent_impl.h (revision 29289)
+++ webkit/glue/webdevtoolsagent_impl.h (working copy)
@@ -10,10 +10,10 @@
#include <wtf/OwnPtr.h>
#include "v8.h"
+#include "webkit/api/public/WebDevToolsAgent.h"
#include "webkit/glue/devtools/devtools_rpc.h"
#include "webkit/glue/devtools/apu_agent_delegate.h"
#include "webkit/glue/devtools/tools_agent.h"
-#include "webkit/glue/webdevtoolsagent.h"
namespace WebCore {
class Document;
@@ -23,6 +23,7 @@
}
namespace WebKit {
+class WebDevToolsAgentClient;
class WebFrame;
}
@@ -30,17 +31,15 @@
class DebuggerAgentDelegateStub;
class DebuggerAgentImpl;
class Value;
-class WebDevToolsAgentDelegate;
class WebFrameImpl;
class WebViewImpl;
-class WebDevToolsAgentImpl
- : public WebDevToolsAgent,
- public ToolsAgent,
- public DevToolsRpc::Delegate {
+class WebDevToolsAgentImpl : public WebKit::WebDevToolsAgent,
+ public ToolsAgent,
+ public DevToolsRpc::Delegate {
public:
WebDevToolsAgentImpl(WebViewImpl* web_view_impl,
- WebDevToolsAgentDelegate* delegate);
+ WebKit::WebDevToolsAgentClient* client);
virtual ~WebDevToolsAgentImpl();
// ToolsAgent implementation.
@@ -56,18 +55,19 @@
virtual void GetResourceContent(
int call_id,
int identifier);
- virtual void SetApuAgentEnabled(bool enable);
// WebDevToolsAgent implementation.
- virtual void Attach();
- virtual void Detach();
- virtual void OnNavigate();
- virtual void DispatchMessageFromClient(const WebKit::WebString& class_name,
- const WebKit::WebString& method_name,
- const WebKit::WebString& param1,
- const WebKit::WebString& param2,
- const WebKit::WebString& param3);
- virtual void InspectElement(int x, int y);
+ virtual void attach();
+ virtual void detach();
+ virtual void didNavigate();
+ virtual void dispatchMessageFromFrontend(
+ const WebKit::WebString& class_name,
+ const WebKit::WebString& method_name,
+ const WebKit::WebString& param1,
+ const WebKit::WebString& param2,
+ const WebKit::WebString& param3);
+ virtual void inspectElementAt(const WebKit::WebPoint& point);
+ virtual void setApuAgentEnabled(bool enable);
// DevToolsRpc::Delegate implementation.
void SendRpcMessage(const WebCore::String& class_name,
@@ -104,7 +104,7 @@
v8::Local<v8::Object> CreateInspectorBackendV8Wrapper();
int host_id_;
- WebDevToolsAgentDelegate* delegate_;
+ WebKit::WebDevToolsAgentClient* client_;
WebViewImpl* web_view_impl_;
OwnPtr<DebuggerAgentDelegateStub> debugger_agent_delegate_stub_;
OwnPtr<ToolsAgentDelegateStub> tools_agent_delegate_stub_;
« no previous file with comments | « webkit/glue/webdevtoolsagent_delegate.h ('k') | webkit/glue/webdevtoolsagent_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698