Allowing `e` of any type in `void f(...) => e`

Allowing `e` of any type in `void f(...) => e` in the analyzer.

Addresses https://github.com/dart-lang/sdk/issues/28940.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/025b83fb892e02bd8465d83bd51c5d1fb3b21235

[eernst, 2017-05-09 13:33:07]

eernst@google.com changed reviewers:
+ brianwilkerson@google.com

[eernst, 2017-05-09 13:33:08]

To address SDK issue #28940, this CL allows all types of `e` in an `=>` void
function and adds a test for it.

It does so by indicating to `_checkForReturnOfInvalidType` in a new named bool
arg when the context is such a function. Language tests run.

[eernst, 2017-05-09 13:51:56]

Completed more tests:

Test configurations: dart2analyzer_none_release_x64
dart2analyzer_none_release_x64
[01:22 | 100% | +18427 | -    0].

[eernst, 2017-05-09 14:00:06]

Description was changed from

==========
Allowing `e` of any type in `void f(...) => e`

Addresses https://github.com/dart-lang/sdk/issues/28940.
==========

to

==========
Allowing `e` of any type in `void f(...) => e` in the analyzer.

Addresses https://github.com/dart-lang/sdk/issues/28940.
==========

[Brian Wilkerson, 2017-05-09 15:33:11]

lgtm

[eernst, 2017-05-10 09:37:14]

Description was changed from

==========
Allowing `e` of any type in `void f(...) => e` in the analyzer.

Addresses https://github.com/dart-lang/sdk/issues/28940.
==========

to

==========
Allowing `e` of any type in `void f(...) => e` in the analyzer.

Addresses https://github.com/dart-lang/sdk/issues/28940.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/025b83fb892e02bd8465d83bd51c5d1fb3b21235
==========

[eernst, 2017-05-10 09:37:15]

Committed patchset #3 (id:40001) manually as
025b83fb892e02bd8465d83bd51c5d1fb3b21235 (presubmit successful).