[Mac] Adjust omnibox decoration dragging to keep image under mouse.

chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.h"
 
 #include "base/logging.h"
 #import "chrome/browser/cocoa/image_utils.h"
 #import "chrome/browser/cocoa/location_bar/autocomplete_text_field.h"
 #import "chrome/browser/cocoa/location_bar/location_bar_decoration.h"
@@ skipping 313 matching lines @@
         [NSDate dateWithTimeIntervalSinceNow:kLocationIconDragTimeout];
     NSEvent* event = [NSApp nextEventMatchingMask:(NSLeftMouseDraggedMask |
                                                    NSLeftMouseUpMask)
                                         untilDate:timeout
                                            inMode:NSEventTrackingRunLoopMode
                                           dequeue:YES];
     if (!event || [event type] == NSLeftMouseDragged) {
       NSPasteboard* pboard = decoration->GetDragPasteboard();
       DCHECK(pboard);
 
-      // TODO(shess): My understanding is that the -isFlipped
-      // adjustment should not be necessary.  But without it, the
-      // image is nowhere near the cursor.  Perhaps the decorations's
-      // rect is incorrectly calculated?
-      // http://crbug.com/40711
-      NSPoint dragPoint = decorationRect.origin;
-      if ([controlView isFlipped])
-        dragPoint.y += NSHeight(decorationRect);
-
       NSImage* image = decoration->GetDragImage();
       DCHECK(image);
-      [controlView dragImage:image
-                          at:dragPoint
-                      offset:NSZeroSize
-                       event:event ? event : theEvent
-                  pasteboard:pboard
-                      source:self
-                   slideBack:YES];
+
+      NSRect dragImageRect = decoration->GetDragImageFrame(decorationRect);
+
+      // If the original click is not within |dragImageRect|, then
+      // center the image under the mouse.  Otherwise, will drag from
+      // where the click was on the image.
+      const NSPoint mousePoint =
+          [controlView convertPoint:[theEvent locationInWindow] fromView:nil];
+      if (!NSMouseInRect(mousePoint, dragImageRect, [controlView isFlipped])) {
+        dragImageRect.origin =
+            NSMakePoint(mousePoint.x - NSWidth(dragImageRect) / 2.0,
+                        mousePoint.y - NSHeight(dragImageRect) / 2.0);
+      }
+
+      // -[NSView dragImage:at:*] wants the images lower-left point,
+      // regardless of -isFlipped.  Converting the rect to window base
+      // coordinates doesn't require any special-casing.  Note that
+      // -[NSView dragFile:fromRect:*] takes a rect rather than a
+      // point, likely for this exact reason.
+      const NSPoint dragPoint =
+          [controlView convertRect:dragImageRect toView:nil].origin;
+      [[controlView window] dragImage:image
+                                   at:dragPoint
+                               offset:NSZeroSize
+                                event:theEvent
+                           pasteboard:pboard
+                               source:self
+                            slideBack:YES];
+
       return YES;
     }
 
     // On mouse-up fall through to mouse-pressed case.
     DCHECK_EQ([event type], NSLeftMouseUp);
   }
 
   if (!decoration->OnMousePressed(decorationRect))
     return NO;
 
@@ skipping 13 matching lines @@
                             &decorations, &decorationFrames, &textFrame);
 
   for (size_t i = 0; i < decorations.size(); ++i) {
     NSString* tooltip = decorations[i]->GetToolTip();
     if ([tooltip length] > 0)
       [controlView addToolTip:tooltip forRect:decorationFrames[i]];
   }
 }
 
 @end