[Mac] Adjust omnibox decoration dragging to keep image under mouse.

[Mac] Adjust omnibox decoration dragging to keep image under mouse.

LocationBarDecoration::GetDragImageFrame() added to let decorations
specify where their GetDragImage() image is in the decoration.  The
mouse-down code ensures that the mouse drags from the expected point
within that area, or centeres the image under the mouse if the drag is
from somewhere else in the decoration.

Additionally tracked down why -isFlipped affected the drag point and
rewrote the code to be -isFlipped agnostic.

BUG=49102, 40771
TEST=Goto https://www.thawte.com/.  Drag from ev text, lock icon should be under cursor.
TEST=drag from location or lock icon should drag from point in icon mouse click was in.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52959

[Scott Hess, 2010-07-18 17:13:27]

Trung, figure out need another reason to dislike flipped views ...

[vtl, 2010-07-18 17:50:47]

Crap, wrong account. Oh well.

http://codereview.chromium.org/2870059/diff/1/2
File chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm (right):

http://codereview.chromium.org/2870059/diff/1/2#newcode538
chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm:538: // center
the image under the mouse.  Otherwise, will drag from
"will drag from the where"?

http://codereview.chromium.org/2870059/diff/1/2#newcode548
chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm:548: //
-dragImage:at:* wants the point of the lower-left corner of
Nit: could you reformat/rewrap this comment to take as little vertical space as
possible?

http://codereview.chromium.org/2870059/diff/1/3
File chrome/browser/cocoa/location_bar/bubble_decoration.h (right):

http://codereview.chromium.org/2870059/diff/1/3#newcode39
chrome/browser/cocoa/location_bar/bubble_decoration.h:39: // Helper to return
the rectangle the image is drawn in, for
Two questions:
- What coordinate system?
- What's the |frame| argument?

http://codereview.chromium.org/2870059/diff/1/6
File chrome/browser/cocoa/location_bar/location_bar_decoration.h (right):

http://codereview.chromium.org/2870059/diff/1/6#newcode64
chrome/browser/cocoa/location_bar/location_bar_decoration.h:64: // appears
correctly under the mouse while dragging.
Probably my previous 2 questions apply here as well.

[Scott Hess, 2010-07-19 13:45:12]

http://codereview.chromium.org/2870059/diff/1/2
File chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm (right):

http://codereview.chromium.org/2870059/diff/1/2#newcode538
chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm:538: // center
the image under the mouse.  Otherwise, will drag from
On 2010/07/18 17:50:47, vtl wrote:
> "will drag from the where"?

Done.

http://codereview.chromium.org/2870059/diff/1/2#newcode548
chrome/browser/cocoa/location_bar/autocomplete_text_field_cell.mm:548: //
-dragImage:at:* wants the point of the lower-left corner of
On 2010/07/18 17:50:47, vtl wrote:
> Nit: could you reformat/rewrap this comment to take as little vertical space
as
> possible?

Managed to remove a couple lines.

http://codereview.chromium.org/2870059/diff/1/3
File chrome/browser/cocoa/location_bar/bubble_decoration.h (right):

http://codereview.chromium.org/2870059/diff/1/3#newcode39
chrome/browser/cocoa/location_bar/bubble_decoration.h:39: // Helper to return
the rectangle the image is drawn in, for
On 2010/07/18 17:50:47, vtl wrote:
> Two questions:
> - What coordinate system?
> - What's the |frame| argument?

Did the latter, not sure what the former is asking for.

http://codereview.chromium.org/2870059/diff/1/6
File chrome/browser/cocoa/location_bar/location_bar_decoration.h (right):

http://codereview.chromium.org/2870059/diff/1/6#newcode64
chrome/browser/cocoa/location_bar/location_bar_decoration.h:64: // appears
correctly under the mouse while dragging.
On 2010/07/18 17:50:47, vtl wrote:
> Probably my previous 2 questions apply here as well.

Guess I assumed "frame" and |frame| might relate somehow for the one question,
and I don't understand the coordinate question.  All decorations are implicitly
in the containing cell's coordinate system.  That's not explicitly documented,
neither is it explicitly documented that a cell is in a control's coordinate
system.

[viettrungluu, 2010-07-19 17:19:14]

LGTM apart from pet peeve resolution.

http://codereview.chromium.org/2870059/diff/5002/7003
File chrome/browser/cocoa/location_bar/bubble_decoration.mm (right):

http://codereview.chromium.org/2870059/diff/5002/7003#newcode115
chrome/browser/cocoa/location_bar/bubble_decoration.mm:115: NSRect
BubbleDecoration::GetImageRectInFrame(NSRect frame) {
Pet peeve: appending method implementations, ignoring the order in which methods
are declared.

Please put this immediately after
|BubbleDecoration::GetWidthForImageAndLabel()|.

[Scott Hess, 2010-07-19 20:24:36]

thanks!

http://codereview.chromium.org/2870059/diff/5002/7003
File chrome/browser/cocoa/location_bar/bubble_decoration.mm (right):

http://codereview.chromium.org/2870059/diff/5002/7003#newcode115
chrome/browser/cocoa/location_bar/bubble_decoration.mm:115: NSRect
BubbleDecoration::GetImageRectInFrame(NSRect frame) {
On 2010/07/19 17:19:15, viettrungluu wrote:
> Pet peeve: appending method implementations, ignoring the order in which
methods
> are declared.
> 
> Please put this immediately after
> |BubbleDecoration::GetWidthForImageAndLabel()|.

Done.