Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 287005: Linux: Fix two issues of omnibox. (Closed)

Created:
11 years, 2 months ago by James Su
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

BUG=23107 Last character of completed path in Omnibar is the wrong color after inline autocomplete BUG=24818 Funky behavior in omnibar editing TEST=Run chromium with a clean profile, then access go/go (or similar url) for several times to make sure inputting 'g' can trigger inline autocomplete. Then input "go/go" and then check if the last char is gray. TEST=Input something into omnibox to trigger inline autocomplete, then press ctrl-right and hold ctrl key, to move the cursor and clear the text selection, then release ctrl key, the text added by inline autocomplete should not be removed.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 2 3 4 4 chunks +37 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Su
11 years, 2 months ago (2009-10-16 10:30:51 UTC) #1
James Su
I just updated this CL to fix issue http://crbug.com/23107 as well, as it's just an ...
11 years, 2 months ago (2009-10-16 11:46:28 UTC) #2
Daniel Erat
OK http://codereview.chromium.org/287005/diff/5001/6001 File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right): http://codereview.chromium.org/287005/diff/5001/6001#newcode806 Line 806: GtkTextIter sstart, send; Mind renaming these to ...
11 years, 2 months ago (2009-10-16 18:59:56 UTC) #3
James Su
11 years, 2 months ago (2009-10-16 23:41:41 UTC) #4
CL Updated.

http://codereview.chromium.org/287005/diff/5001/6001
File chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc (right):

http://codereview.chromium.org/287005/diff/5001/6001#newcode806
Line 806: GtkTextIter sstart, send;
On 2009/10/16 18:59:56, Daniel Erat wrote:
> Mind renaming these to "sel_start" and "sel_end"?  These variable names are
> really vague (and "send" is an completely unrelated word).

Done. I have the same feeling when I saw it.

Powered by Google App Engine
This is Rietveld 408576698