Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 287003011: Initial support for HTTP/2 dependencies and weights (Closed)

Created:
6 years, 7 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Initial support for HTTP/2 dependencies and weights. A non-exclusive root dependency is always emitted, and parsed dependencies are ignored. Weights are mapped to existing SPDY priorities, and vice versa. BUG=345769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271555

Patch Set 1 #

Patch Set 2 : Map HTTP/2 weights to priorities (and vice versa). #

Patch Set 3 : Comment tweaks. #

Total comments: 2

Patch Set 4 : Constants for dependency + weight payload size. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -30 lines) Patch
M net/spdy/spdy_framer.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M net/spdy/spdy_framer.cc View 1 2 3 8 chunks +36 lines, -10 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 2 5 chunks +53 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnny
Last blocker for h2-12 testing in Chromium. Also under concurrent review server-side, but I'm mailing ...
6 years, 7 months ago (2014-05-19 21:14:46 UTC) #1
Ryan Hamilton
LGTM, though consider using constants. https://codereview.chromium.org/287003011/diff/40001/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/287003011/diff/40001/net/spdy/spdy_framer.cc#newcode188 net/spdy/spdy_framer.cc:188: return GetControlFrameHeaderSize() + 5; ...
6 years, 7 months ago (2014-05-19 22:56:41 UTC) #2
Johnny
https://codereview.chromium.org/287003011/diff/40001/net/spdy/spdy_framer.cc File net/spdy/spdy_framer.cc (right): https://codereview.chromium.org/287003011/diff/40001/net/spdy/spdy_framer.cc#newcode188 net/spdy/spdy_framer.cc:188: return GetControlFrameHeaderSize() + 5; On 2014/05/19 22:56:41, Ryan Hamilton ...
6 years, 7 months ago (2014-05-19 23:27:17 UTC) #3
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-19 23:38:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/287003011/100001
6 years, 7 months ago (2014-05-19 23:38:47 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 03:05:13 UTC) #6
Message was sent while issue was closed.
Change committed as 271555

Powered by Google App Engine
This is Rietveld 408576698