Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4465)

Unified Diff: chrome/browser/devtools/device/devtools_android_bridge.cc

Issue 287003006: DevTools: Fixed AndroidDeviceManager destruction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/inspect_ui_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/devtools_android_bridge.cc
diff --git a/chrome/browser/devtools/device/devtools_android_bridge.cc b/chrome/browser/devtools/device/devtools_android_bridge.cc
index 5fefecc91fd06be14e3a306811c07f953321afba..b6ec8ccfe399a05646ce6711adaaa9eb0e861456 100644
--- a/chrome/browser/devtools/device/devtools_android_bridge.cc
+++ b/chrome/browser/devtools/device/devtools_android_bridge.cc
@@ -1259,9 +1259,12 @@ DevToolsAndroidBridge::~DevToolsAndroidBridge() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DCHECK(device_list_listeners_.empty());
DCHECK(device_count_listeners_.empty());
- if (device_manager_)
- device_message_loop()->PostTask(FROM_HERE,
- base::Bind(&AndroidDeviceManager::Stop, device_manager_));
+ if (device_manager_) {
+ AndroidDeviceManager* raw_ptr = device_manager_.get();
+ device_manager_->AddRef();
+ device_manager_ = NULL;
+ device_message_loop()->ReleaseSoon(FROM_HERE, raw_ptr);
+ }
}
void DevToolsAndroidBridge::RequestDeviceList() {
« no previous file with comments | « no previous file | chrome/browser/ui/webui/inspect_ui_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698