Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: trunk/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc

Issue 287003004: Revert 270867 "Mojo: Internalize ServiceConnector<>" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
===================================================================
--- trunk/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc (revision 270872)
+++ trunk/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc (working copy)
@@ -32,15 +32,9 @@
public:
virtual ~MathCalculatorImpl() {}
- MathCalculatorImpl()
- : total_(0.0),
- got_connection_(false) {
+ MathCalculatorImpl() : total_(0.0) {
}
- virtual void OnConnectionEstablished() MOJO_OVERRIDE {
- got_connection_ = true;
- }
-
virtual void OnConnectionError() MOJO_OVERRIDE {
delete this;
}
@@ -59,13 +53,8 @@
client()->Output(total_);
}
- bool got_connection() const {
- return got_connection_;
- }
-
-private:
+ private:
double total_;
- bool got_connection_;
};
class MathCalculatorUIImpl : public math::CalculatorUI {
@@ -127,8 +116,7 @@
TEST_F(InterfacePtrTest, EndToEnd) {
math::CalculatorPtr calc;
- MathCalculatorImpl* impl = BindToProxy(new MathCalculatorImpl(), &calc);
- EXPECT_TRUE(impl->got_connection());
+ BindToProxy(new MathCalculatorImpl(), &calc);
// Suppose this is instantiated in a process that has pipe1_.
MathCalculatorUIImpl calculator_ui(calc.Pass());
« no previous file with comments | « trunk/src/mojo/public/cpp/bindings/lib/interface_impl_internal.h ('k') | trunk/src/mojo/public/cpp/shell/application.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698