chrome/browser/renderer_host/resource_dispatcher_host.cc - Issue 287002: Fix crash bug when attempting to download a url with unsupported scheme, e.g....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/resource_dispatcher_host.cc

Issue 287002: Fix crash bug when attempting to download a url with unsupported scheme, e.g.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/resource_dispatcher_host.cc

===================================================================

--- chrome/browser/renderer_host/resource_dispatcher_host.cc (revision 28527)

+++ chrome/browser/renderer_host/resource_dispatcher_host.cc (working copy)

@@ -729,9 +729,10 @@

receiver_);

}

- bool known_proto = URLRequest::IsHandledURL(url);

- if (!known_proto) {

- CHECK(false);

+ if (!URLRequest::IsHandledURL(url)) {

+ LOG(INFO) << "Download request for unsupported protocol: " <<

+ url.possibly_invalid_spec();

+ return;

}

request->set_method("GET");

« no previous file with comments | « no previous file | no next file » | no next file with comments »