Issue 287001: Mark LayoutTests/fast/css/large-list-of-rules-crash.html as DEBUG SLOW.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 287001: Mark LayoutTests/fast/css/large-list-of-rules-crash.html as DEBUG SLOW. (Closed)

Created:
11 years, 2 months ago by Yuta Kitamura

Modified:
9 years, 7 months ago

Reviewers:
hamaji

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Mark LayoutTests/fast/css/large-list-of-rules-crash.html as DEBUG SLOW. This test takes long time to finish maybe because of V8's debug logging. BUG=24102 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29260

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hamaji

Please move this line to around the following line: // Got slow with V8 update ...

11 years, 2 months ago (2009-10-16 07:52:25 UTC) #2

Yuta Kitamura

On 2009/10/16 07:52:25, hamaji wrote: > Please move this line to around the following line: ...

11 years, 2 months ago (2009-10-16 08:01:17 UTC) #3

hamaji

11 years, 2 months ago (2009-10-16 08:05:41 UTC) #4

On 2009/10/16 08:01:17, Yuta Kitamura wrote:
> On 2009/10/16 07:52:25, hamaji wrote:
> > Please move this line to around the following line:
> Done.

LGTM, thanks!

> > // Got slow with V8 update to 1.3.15. Debug logging perhaps?
> > 
> > By the way, are there any plans to fix this?
> I figured out that rewriting the test to reduce the times of string
> concatenation (200000 times to log(200000) times) fixes the issue. I'm
planning
> to fix this test in upstream.

This sounds pretty good. Please go ahead!

Expand Messages | Collapse Messages