Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: pkg/front_end/test/fasta/testing/suite.dart

Issue 2869953002: Add a "skipVm" option to fasta tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/test/fasta/testing/suite.dart
diff --git a/pkg/front_end/test/fasta/testing/suite.dart b/pkg/front_end/test/fasta/testing/suite.dart
index 6a5eff98f2399d75786cb05e1289277c094f39ac..c302015e65e21f08deb3e9e549a03487413fa95e 100644
--- a/pkg/front_end/test/fasta/testing/suite.dart
+++ b/pkg/front_end/test/fasta/testing/suite.dart
@@ -93,6 +93,7 @@ class FastaContext extends ChainContext {
bool strongMode,
bool updateExpectations,
bool updateComments,
+ bool skipVm,
this.uriTranslator,
bool fullCompile,
AstKind astKind)
@@ -107,7 +108,7 @@ class FastaContext extends ChainContext {
: ".outline.expect",
updateExpectations: updateExpectations)
] {
- if (fullCompile) {
+ if (fullCompile && !skipVm) {
steps.add(const WriteDill());
steps.add(const Run());
}
@@ -130,11 +131,19 @@ class FastaContext extends ChainContext {
bool strongMode = environment.containsKey(STRONG_MODE);
bool updateExpectations = environment["updateExpectations"] == "true";
bool updateComments = environment["updateComments"] == "true";
+ bool skipVm = environment["skipVm"] == "true";
String astKindString = environment[AST_KIND_INDEX];
AstKind astKind =
astKindString == null ? null : AstKind.values[int.parse(astKindString)];
- return new FastaContext(vm, strongMode, updateExpectations, updateComments,
- uriTranslator, environment.containsKey(ENABLE_FULL_COMPILE), astKind);
+ return new FastaContext(
+ vm,
+ strongMode,
+ updateExpectations,
+ updateComments,
+ skipVm,
+ uriTranslator,
+ environment.containsKey(ENABLE_FULL_COMPILE),
+ astKind);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698