Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2869953002: Add a "skipVm" option to fasta tests. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a "skipVm" option to fasta tests. This makes it easy to identify tests that pass in Fasta but fail in the VM. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e3cb466a5ffac9e521423d5bb14bec6b98680be7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M pkg/front_end/test/fasta/testing/suite.dart View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-08 20:47:48 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-08 22:29:45 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as e3cb466a5ffac9e521423d5bb14bec6b98680be7 (presubmit successful).
3 years, 7 months ago (2017-05-08 23:10:27 UTC) #5
ahe
3 years, 7 months ago (2017-05-11 12:42:40 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698