For media element fetches, remove user:pass components always.

For media element fetches, remove user:pass components always.

The compatible behavior for media element fetches is to ignore any
authorization information embedded in the URL. Insist on that by removing
the user and password components before starting the fetch.

Not doing so currently asserts in DocumentThreadableLoader::loadRequest(),
which expects that portion of the URL to have been processed already,
and removed. Satisfy that expectation here.

R=japhet@chromium.org,acolwell@chromium.org,philipj@opera.com
BUG=357269
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174248

[sof, 2014-05-16 16:02:47]

Please take a look.

[Nate Chapin, 2014-05-16 16:55:36]

LGTM with some pedantry.

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:893: // Compatible behavior, and what the
embedder currently does
Grammar Nit: I'm not 100% sure I've read this correctly. Should this be "This is
compatible behavior, ...", referring to the last sentence?

[acolwell GONE FROM CHROMIUM, 2014-05-16 17:32:19]

lgtm % comments

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:876: startLoad();
nit: s/startLoad/startPlayerLoad/ just to make it clear that this isn't
referring to the HTMLMediaElement load()

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:894: // regardless.
Please put relevant spec references for this behavior.

[sof, 2014-05-16 19:51:30]

Thanks for the quick reviews.

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:876: startLoad();
On 2014/05/16 17:32:19, acolwell wrote:
> nit: s/startLoad/startPlayerLoad/ just to make it clear that this isn't
> referring to the HTMLMediaElement load()

That's a clearer name, thanks.

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:893: // Compatible behavior, and what the
embedder currently does
On 2014/05/16 16:55:36, Nate Chapin wrote:
> Grammar Nit: I'm not 100% sure I've read this correctly. Should this be "This
is
> compatible behavior, ...", referring to the last sentence?

I tried to make the comment minimal, but compressed it too much, I suppose.
Expanded it a bit, and hopefully also clearer.

https://codereview.chromium.org/286993008/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:894: // regardless.
On 2014/05/16 17:32:19, acolwell wrote:
> Please put relevant spec references for this behavior.

Done, but the treatment of these URL forms isn't (yet) covered by the spec.
Fetch does cover this, we just have to wait for the HTML spec to "fetch-ify" its
various resource fetch algorithms. Expanded the FIXME to make that clear.

[philipj_slow, 2014-05-16 22:24:54]

LGTM too.

[sof, 2014-05-17 05:53:43]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-05-17 05:54:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/286993008/20001

[commit-bot: I haz the power, 2014-05-17 23:56:04]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7655)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7437)

[sof, 2014-05-18 04:51:03]

The CQ bit was unchecked by sigbjornf@opera.com

[sof, 2014-05-18 04:52:29]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-05-18 04:52:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/286993008/20001

[commit-bot: I haz the power, 2014-05-18 23:57:37]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/7655)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7437)

[commit-bot: I haz the power, 2014-05-19 07:27:42]

Change committed as 174248