Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 286993002: [Bluetooth] Use base::ToLowerASCII() rather than tolower(), as the later is locale-sensitive. (Closed)

Created:
6 years, 7 months ago by Ilya Sherman
Modified:
6 years, 7 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Visibility:
Public.

Description

[Bluetooth] Use base::ToLowerASCII() rather than tolower(), as the later is locale-sensitive. BUG=373096 TEST=none R=keybuk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/bluetooth/bluetooth_uuid.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
6 years, 7 months ago (2014-05-15 03:47:57 UTC) #1
keybuk
lgtm
6 years, 7 months ago (2014-05-15 21:29:14 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-15 21:36:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/286993002/1
6 years, 7 months ago (2014-05-15 21:37:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 23:55:48 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 02:01:33 UTC) #6
Message was sent while issue was closed.
Change committed as 270897

Powered by Google App Engine
This is Rietveld 408576698