Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2869923003: Fix crash trying to fire event on destroying Widget with no root view (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash trying to fire event on destroying Widget with no root view Widget::GetRootView() is almost always valid, but not during tear-down. BUG=718135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/accessibility/ax_window_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
dmazzoni
3 years, 7 months ago (2017-05-08 21:37:05 UTC) #3
David Tseng
lgtm
3 years, 7 months ago (2017-05-08 22:48:22 UTC) #5
dmazzoni
3 years, 7 months ago (2017-05-09 05:18:19 UTC) #8 
Same fix as:
https://codereview.chromium.org/2865923004/

Closing this one

Powered by Google App Engine
This is Rietveld 408576698