[ios clean] Dismisses ToolsMenu on Layout changes.

ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h"
 
 #import "base/mac/foundation_util.h"
 #import "ios/clean/chrome/browser/ui/actions/tab_strip_actions.h"
 #import "ios/clean/chrome/browser/ui/commands/navigation_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"
@@ skipping 16 matching lines @@
 @property(nonatomic, strong) UIView* locationBarContainer;
 @property(nonatomic, strong) UIStackView* stackView;
 @property(nonatomic, strong) ToolbarButton* backButton;
 @property(nonatomic, strong) ToolbarButton* forwardButton;
 @property(nonatomic, strong) ToolbarButton* tabSwitchStripButton;
 @property(nonatomic, strong) ToolbarButton* tabSwitchGridButton;
 @property(nonatomic, strong) ToolbarButton* toolsMenuButton;
 @property(nonatomic, strong) ToolbarButton* shareButton;
 @property(nonatomic, strong) ToolbarButton* reloadButton;
 @property(nonatomic, strong) ToolbarButton* stopButton;
+@property(nonatomic, assign) CGRect currentFrame;
 @end
 
 @implementation ToolbarViewController
 @synthesize dispatcher = _dispatcher;
 @synthesize locationBarViewController = _locationBarViewController;
 @synthesize stackView = _stackView;
 @synthesize locationBarContainer = _locationBarContainer;
 @synthesize backButton = _backButton;
 @synthesize forwardButton = _forwardButton;
 @synthesize tabSwitchStripButton = _tabSwitchStripButton;
 @synthesize tabSwitchGridButton = _tabSwitchGridButton;
 @synthesize toolsMenuButton = _toolsMenuButton;
 @synthesize shareButton = _shareButton;
 @synthesize reloadButton = _reloadButton;
 @synthesize stopButton = _stopButton;
+@synthesize currentFrame = _currentFrame;
 
 - (instancetype)init {
   self = [super init];
   if (self) {
     [self setUpToolbarButtons];
     [self setUpLocationBarContainer];
   }
   return self;
 }
 
+#pragma mark - View lifecyle
+
 - (void)viewDidLoad {
   self.view.backgroundColor = [UIColor lightGrayColor];
 
   [self addChildViewController:self.locationBarViewController
                      toSubview:self.locationBarContainer];
 
   // Stack view to contain toolbar items.
   self.stackView = [[UIStackView alloc] initWithArrangedSubviews:@[
     self.backButton, self.forwardButton, self.reloadButton, self.stopButton,
     self.locationBarContainer, self.shareButton, self.tabSwitchStripButton,
@@ skipping 13 matching lines @@
                                              constant:kVerticalMargin],
     [self.stackView.bottomAnchor constraintEqualToAnchor:self.view.bottomAnchor
                                                 constant:-kVerticalMargin],
     [self.stackView.leadingAnchor
         constraintEqualToAnchor:self.view.leadingAnchor
                        constant:kHorizontalMargin],
     [self.stackView.trailingAnchor
         constraintEqualToAnchor:self.view.trailingAnchor
                        constant:-kHorizontalMargin],
   ]];
+
+  self.currentFrame = self.view.frame;
+}
+
+- (void)viewWillLayoutSubviews {
+  // We need to dismiss the ToolsMenu everytime the Toolbar frame changes
+  // (e.g. Size changes, rotation changes, etc.)
+  if (!CGRectEqualToRect(self.currentFrame, self.view.frame)) {

[marq (ping after 24h), 2017/05/10 10:57:02]

UIViewController (via the UIContentContainer protocol which it conforms to) has
a method specifically for catching changes to its view size:
-viewWillTransitionToSize:withTransitionCoordinator:. I think that's what you
should use for this. 

[sczs, 2017/05/10 15:32:32]

I agree, its much better.
Done.

+    [self.dispatcher closeToolsMenu];
+  }
+  self.currentFrame = self.view.frame;
 }
 
 #pragma mark - Components Setup
 
 - (void)setUpToolbarButtons {
   // Back button.
   self.backButton = [ToolbarButton backToolbarButton];
   self.backButton.visibilityMask = ToolbarComponentVisibilityCompactWidth |
                                    ToolbarComponentVisibilityRegularWidth;
   [self.backButton addTarget:self
@@ skipping 202 matching lines @@
 - (void)updateAllButtonsVisibility {
   for (UIView* view in self.stackView.arrangedSubviews) {
     if ([view isKindOfClass:[ToolbarButton class]]) {
       ToolbarButton* button = base::mac::ObjCCastStrict<ToolbarButton>(view);
       [button setHiddenForCurrentStateAndSizeClass];
     }
   }
 }
 
 @end