[ios clean] Dismisses ToolsMenu on Layout changes.

ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_view_controller.h"
 
 #import "base/mac/foundation_util.h"
 #import "ios/clean/chrome/browser/ui/actions/tab_strip_actions.h"
 #import "ios/clean/chrome/browser/ui/commands/navigation_commands.h"
 #import "ios/clean/chrome/browser/ui/commands/tab_grid_commands.h"
@@ skipping 41 matching lines @@
 
 - (instancetype)init {
   self = [super init];
   if (self) {
     [self setUpToolbarButtons];
     [self setUpLocationBarContainer];
   }
   return self;
 }
 
+#pragma mark - View lifecyle
+
 - (void)viewDidLoad {
   self.view.backgroundColor = [UIColor lightGrayColor];
 
   [self addChildViewController:self.locationBarViewController
                      toSubview:self.locationBarContainer];
 
   // Stack view to contain toolbar items.
   self.stackView = [[UIStackView alloc] initWithArrangedSubviews:@[
     self.backButton, self.forwardButton, self.reloadButton, self.stopButton,
     self.locationBarContainer, self.shareButton, self.tabSwitchStripButton,
@@ skipping 15 matching lines @@
                                                 constant:-kVerticalMargin],
     [self.stackView.leadingAnchor
         constraintEqualToAnchor:self.view.leadingAnchor
                        constant:kHorizontalMargin],
     [self.stackView.trailingAnchor
         constraintEqualToAnchor:self.view.trailingAnchor
                        constant:-kHorizontalMargin],
   ]];
 }
 
+- (void)viewWillLayoutSubviews {
+  // We need to dismiss the ToolsMenu everytime the Toolbar position changes
+  // (e.g. Size changes, rotation changes, etc.)
+  [self.dispatcher closeToolsMenu];

[marq (ping after 24h), 2017/05/09 12:13:26]

I'm pretty sure this isn't what we want. What if setCanGoForward:NO is called by
the mediator while the menu is showing? That will cause the forward button to
hide, which will trigger a layout pass, which will dismiss the tools menu.

[sczs, 2017/05/10 02:25:46]

Completely right, thanks for pointing this out. I tried a couple of things but I
think checking if the frame changed is our best bet all things considered.

I also tried setting a flag for Toolbar Button visibility changes, but any new
component would still trigger the dismissal. I think the approach I chose is the
most maintainable. 

+}
+
 #pragma mark - Components Setup
 
 - (void)setUpToolbarButtons {
   // Back button.
   self.backButton = [ToolbarButton backToolbarButton];
   self.backButton.visibilityMask = ToolbarComponentVisibilityCompactWidth |
                                    ToolbarComponentVisibilityRegularWidth;
   [self.backButton addTarget:self
                       action:@selector(goBack:)
             forControlEvents:UIControlEventTouchUpInside];
@@ skipping 200 matching lines @@
 - (void)updateAllButtonsVisibility {
   for (UIView* view in self.stackView.arrangedSubviews) {
     if ([view isKindOfClass:[ToolbarButton class]]) {
       ToolbarButton* button = base::mac::ObjCCastStrict<ToolbarButton>(view);
       [button setHiddenForCurrentStateAndSizeClass];
     }
   }
 }
 
 @end