Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: PRESUBMIT.py

Issue 2869893003: New Sequence/Thread checking API. (Closed)
Patch Set: fix tests in non-dcheck builds, need fixture can't use lambdas Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/sequence_checker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 ( 322 (
323 'BrowserThread::GetBlockingPool', 323 'BrowserThread::GetBlockingPool',
324 ( 324 (
325 'Use base/task_scheduler/post_task.h instead of the blocking pool. See', 325 'Use base/task_scheduler/post_task.h instead of the blocking pool. See',
326 'mapping between both APIs in content/public/browser/browser_thread.h.', 326 'mapping between both APIs in content/public/browser/browser_thread.h.',
327 'For questions, contact base/task_scheduler/OWNERS.', 327 'For questions, contact base/task_scheduler/OWNERS.',
328 ), 328 ),
329 True, 329 True,
330 (), 330 (),
331 ), 331 ),
332 (
333 'base::NonThreadSafe',
334 (
335 'base::NonThreadSafe is deprecated.',
336 ),
337 True,
338 (),
339 ),
340 (
341 'base::SequenceChecker',
342 (
343 'Consider using SEQUENCE_CHECKER macros instead of the class directly.',
344 ),
345 False,
346 (),
347 ),
348 (
349 'base::ThreadChecker',
350 (
351 'Consider using THREAD_CHECKER macros instead of the class directly.',
352 ),
353 False,
354 (),
355 ),
332 ) 356 )
333 357
334 358
335 _IPC_ENUM_TRAITS_DEPRECATED = ( 359 _IPC_ENUM_TRAITS_DEPRECATED = (
336 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' 360 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n'
337 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc') 361 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc')
338 362
339 363
340 _VALID_OS_MACROS = ( 364 _VALID_OS_MACROS = (
341 # Please keep sorted. 365 # Please keep sorted.
(...skipping 2122 matching lines...) Expand 10 before | Expand all | Expand 10 after
2464 output_api, 2488 output_api,
2465 json_url='http://chromium-status.appspot.com/current?format=json')) 2489 json_url='http://chromium-status.appspot.com/current?format=json'))
2466 2490
2467 results.extend( 2491 results.extend(
2468 input_api.canned_checks.CheckPatchFormatted(input_api, output_api)) 2492 input_api.canned_checks.CheckPatchFormatted(input_api, output_api))
2469 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2493 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2470 input_api, output_api)) 2494 input_api, output_api))
2471 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2495 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2472 input_api, output_api)) 2496 input_api, output_api))
2473 return results 2497 return results
OLDNEW
« no previous file with comments | « no previous file | base/sequence_checker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698