Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: tools/chrome_proxy/webdriver/quic.py

Issue 2869863002: Enable QUIC for non core data saver proxies (Closed)
Patch Set: Reorder functions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/chrome_proxy/webdriver/quic.py
diff --git a/tools/chrome_proxy/webdriver/quic.py b/tools/chrome_proxy/webdriver/quic.py
index 280bfb92887e99bf861b130253e4f93473b43f07..bd57e1177a65461b52ed011b11e89c33069b102f 100644
--- a/tools/chrome_proxy/webdriver/quic.py
+++ b/tools/chrome_proxy/webdriver/quic.py
@@ -17,10 +17,16 @@ class Quic(IntegrationTest):
def testCheckPageWithQuicProxy(self):
with TestDriver() as t:
t.AddChromeArg('--enable-spdy-proxy-auth')
+
+ # Enable QUIC (including for non-core HTTPS proxies).
t.AddChromeArg('--enable-quic')
- # Enable QUIC for non-core HTTPS proxies.
- t.AddChromeArg('--data-reduction-proxy-enable-quic-on-non-core-proxies')
t.AddChromeArg('--force-fieldtrials=DataReductionProxyUseQuic/Enabled')
+ t.AddChromeArg('--force-fieldtrial-params='
+ 'DataReductionProxyUseQuic.Enabled:enable_quic_non_core_proxies/true')
+ # Enable usage of QUIC for non-core proxies via switch for older versions
+ # of Chrome (M-59 and prior).
+ t.AddChromeArg('--data-reduction-proxy-enable-quic-on-non-core-proxies')
+
t.LoadURL('http://check.googlezip.net/test.html')
responses = t.GetHTTPResponses()
self.assertEqual(2, len(responses))
@@ -32,10 +38,16 @@ class Quic(IntegrationTest):
def testCheckPageWithQuicProxyTransaction(self):
with TestDriver() as t:
t.AddChromeArg('--enable-spdy-proxy-auth')
+
+ # Enable QUIC (including for non-core HTTPS proxies).
t.AddChromeArg('--enable-quic')
- # Enable QUIC for non-core HTTPS proxies.
- t.AddChromeArg('--data-reduction-proxy-enable-quic-on-non-core-proxies')
t.AddChromeArg('--force-fieldtrials=DataReductionProxyUseQuic/Enabled')
+ t.AddChromeArg('--force-fieldtrial-params='
+ 'DataReductionProxyUseQuic.Enabled:enable_quic_non_core_proxies/true')
+ # Enable usage of QUIC for non-core proxies via switch for older versions
+ # of Chrome (M-59 and prior).
+ t.AddChromeArg('--data-reduction-proxy-enable-quic-on-non-core-proxies')
+
t.LoadURL('http://check.googlezip.net/test.html')
responses = t.GetHTTPResponses()
self.assertEqual(2, len(responses))
« no previous file with comments | « components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698