tools/chrome_proxy/webdriver/quic.py - Issue 2869863002: Enable QUIC for non core data saver proxies

Unified Diff: tools/chrome_proxy/webdriver/quic.py

Issue 2869863002: Enable QUIC for non core data saver proxies (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc ('K') | « components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/webdriver/quic.py

diff --git a/tools/chrome_proxy/webdriver/quic.py b/tools/chrome_proxy/webdriver/quic.py

index 280bfb92887e99bf861b130253e4f93473b43f07..5219f5b3981a45becb66faee6873f5d0b8612887 100644

--- a/tools/chrome_proxy/webdriver/quic.py

+++ b/tools/chrome_proxy/webdriver/quic.py

@@ -17,10 +17,16 @@ class Quic(IntegrationTest):

def testCheckPageWithQuicProxy(self):

with TestDriver() as t:

t.AddChromeArg('--enable-spdy-proxy-auth')

+ # Enable QUIC (including for non-core HTTPS proxies).

t.AddChromeArg('--enable-quic')

- # Enable QUIC for non-core HTTPS proxies.

- t.AddChromeArg('--data-reduction-proxy-enable-quic-on-non-core-proxies')

t.AddChromeArg('--force-fieldtrials=DataReductionProxyUseQuic/Enabled')

+ t.AddChromeArg('--force-fieldtrial-params='

+ 'DataReductionProxyUseQuic.Enabled:enable_quic_non_core_proxies/true')

+ # Enable usage of QUIC for non-core proxies via switch for older versions

+ # of Chrome.

megjablon 2017/05/09 18:16:22 Can you add the version for this change? Something

tbansal1 2017/05/09 23:57:41 Done.

+ t.AddChromeArg('--data-reduction-proxy-enable-quic-on-non-core-proxies')

t.LoadURL('http://check.googlezip.net/test.html')

responses = t.GetHTTPResponses()

self.assertEqual(2, len(responses))

@@ -32,10 +38,16 @@ class Quic(IntegrationTest):

def testCheckPageWithQuicProxyTransaction(self):