Enable QUIC for non core data saver proxies

components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
 
 #include <stddef.h>
 
 #include <map>
 #include <string>
@@ skipping 438 matching lines @@
     if (!test.warmup_url.empty()) {
       EXPECT_EQ(GURL(test.warmup_url), params::GetWarmupURL());
     } else {
       EXPECT_EQ(GURL("http://check.googlezip.net/generate_204"),
                 params::GetWarmupURL());
     }
     EXPECT_EQ(test.expect_warmup_url_enabled, params::FetchWarmupURLEnabled());
   }
 }
 
+// Tests if the QUIC field trial |enable_quic_non_core_proxies| is set
+// correctly.
+TEST_F(DataReductionProxyParamsTest, QuicEnableNonCoreProxies) {
+  const struct {
+    std::string trial_group_name;
+    bool expected_enabled;
+    std::string enable_non_core_proxies;
+    bool expected_enable_non_core_proxies;
+  } tests[] = {
+      {"Enabled", true, "true", true},
+      {"Enabled", true, "false", false},
+      {"Enabled", true, std::string(), false},
+      {"Control", false, "true", true},

[megjablon, 2017/05/10 23:11:24]

Shouldn't this case not happen since IsIncludedInQuicFieldTrial should be true
for noncore proxies to be enabled?

[tbansal1, 2017/05/11 01:29:28]

Right. When QUIC is not enabled, behavior of IsQuicForNonCoreProxiesEnabled() is
undefined.
IsQuicForNonCoreProxiesEnabled() should be called only when QUIC is enabled.
There is a DCHECK in IsQuicForNonCoreProxiesEnabled() which ensures that.

+      {"Disabled", false, "false", false},
+  };
+
+  for (const auto& test : tests) {
+    variations::testing::ClearAllVariationParams();
+    std::map<std::string, std::string> variation_params;
+    variation_params["enable_quic_non_core_proxies"] =
+        test.enable_non_core_proxies;
+
+    ASSERT_TRUE(variations::AssociateVariationParams(
+        params::GetQuicFieldTrialName(), test.trial_group_name,
+        variation_params));
+
+    base::FieldTrialList field_trial_list(nullptr);
+    base::FieldTrialList::CreateFieldTrial(params::GetQuicFieldTrialName(),
+                                           test.trial_group_name);
+
+    EXPECT_EQ(test.expected_enabled, params::IsIncludedInQuicFieldTrial());
+    if (params::IsIncludedInQuicFieldTrial()) {
+      EXPECT_EQ(test.expected_enable_non_core_proxies,
+                params::IsQuicForNonCoreProxiesEnabled());
+    }
+  }
+}
+
 TEST_F(DataReductionProxyParamsTest, HoldbackEnabledFieldTrial) {
   const struct {
     std::string trial_group_name;
     bool expected_enabled;
   } tests[] = {
       {"Enabled", true},
       {"Enabled_Control", true},
       {"Disabled", false},
       {"enabled", false},
   };
@@ skipping 70 matching lines @@
       ProxyServer::UNSPECIFIED_TYPE));
   expected_override_proxies_for_http.push_back(DataReductionProxyServer(
       net::ProxyServer::FromURI("http://override-second.net",
                                 net::ProxyServer::SCHEME_HTTP),
       ProxyServer::UNSPECIFIED_TYPE));
 
   EXPECT_EQ(expected_override_proxies_for_http, params.proxies_for_http());
 }
 
 }  // namespace data_reduction_proxy