Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 286983005: Add icon resoueces for shared folder. (Closed)

Created:
6 years, 7 months ago by fukino
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add icon resoueces for shared folder. BUG=264812 TEST=manually confirmed R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271354

Patch Set 1 #

Messages

Total messages: 10 (0 generated)
fukino
oshima san, could you take a look?
6 years, 7 months ago (2014-05-16 06:06:52 UTC) #1
oshima
lgtm
6 years, 7 months ago (2014-05-16 06:15:39 UTC) #2
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-16 06:17:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/286983005/1
6 years, 7 months ago (2014-05-16 06:18:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 06:50:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 06:51:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68077) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27719) linux_chromium_clang_dbg ...
6 years, 7 months ago (2014-05-16 06:51:51 UTC) #7
oshima
you need to dcommit binary png files.
6 years, 7 months ago (2014-05-16 13:57:53 UTC) #8
fukino
On 2014/05/16 13:57:53, oshima wrote: > you need to dcommit binary png files. Thanks! I ...
6 years, 7 months ago (2014-05-16 14:10:21 UTC) #9
yoshiki
6 years, 7 months ago (2014-05-19 08:55:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 manually as r271354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698