third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp - Issue 2869813002: Fix the bug that absolute positioned element moves unexpectedly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2869813002: Fix the bug that absolute positioned element moves unexpectedly (Closed)

Patch Set: Add test expectation Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

index 5e53c85a0c55a915cd601708bf6e454d14848588..1050d0e71337960e56b8a8e2dd89c574649c09f0 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

@@ -147,7 +147,7 @@ CompositingReasons CompositingReasonFinder::NonStyleDeterminedDirectReasons(

CompositingReasons direct_reasons = kCompositingReasonNone;

LayoutObject& layout_object = layer->GetLayoutObject();

- if (compositing_triggers_ & kOverflowScrollTrigger && layer->ClipParent())

+ if (layer->ClipParent())

direct_reasons |= kCompositingReasonOutOfFlowClipping;

if (layer->NeedsCompositedScrolling())