Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2869803004: Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move [file_]byte_store.dart into pkg/front_end/test/src/incremental/. We are going to reuse ByteStore in front_end, also for incremental compilation. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bd1ee32543f0641f5c0503d208bbbc47cd651da1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -439 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/search_engine2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_watcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analyzer/lib/src/dart/analysis/byte_store.dart View 1 chunk +0 lines, -111 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analyzer/lib/src/dart/analysis/file_byte_store.dart View 1 chunk +0 lines, -171 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/library_context.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 2 chunks +1 line, -1 line 0 comments Download
D pkg/analyzer/test/src/dart/analysis/byte_store_test.dart View 1 chunk +0 lines, -121 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/dart/analysis/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 4 chunks +14 lines, -14 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/test/support/abstract_context.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/front_end/lib/src/incremental/byte_store.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/front_end/lib/src/incremental/file_byte_store.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart View 2 chunks +1 line, -1 line 0 comments Download
A + pkg/front_end/test/src/incremental/byte_store_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 7 months ago (2017-05-09 05:11:25 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-09 12:34:30 UTC) #2
Brian Wilkerson
Is the angular plugin using these classes? If so, should we leave the original files ...
3 years, 7 months ago (2017-05-09 15:32:13 UTC) #3
scheglov
3 years, 7 months ago (2017-05-09 16:12:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
bd1ee32543f0641f5c0503d208bbbc47cd651da1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698