Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2869763004: Fix DPI scaling on Linux with GTK3 (Closed)

Created:
3 years, 7 months ago by Tom (Use chromium acct)
Modified:
3 years, 7 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DPI scaling on Linux with GTK3 The device scale was determined by querying the value of the "gtk-xft-dpi" property from GtkSettings. In GTK2, this always returned the value of the "Xft/DPI" XSettings property. However, in GTK3, this returns the value of "Gdk/UnscaledDPI" if it is set, resulting in the wrong device scale being calculated on high DPI screens. Instead, we now query the "gdk-window-scaling-factor" setting from GdkScreen, which is derived from the value of the "Gdk/WindowScalingFactor" XSettings property. If this property is not set then we fall back to the previous code path, as environments that don't provide Gdk/WindowScalingFactor also won't provide Gdk/UnscaledDPI. BUG=716135 TBR=erg@chromium.org patch from issue 2852593002 at patchset 20001 (http://crrev.com/2852593002#ps20001) Review-Url: https://codereview.chromium.org/2869763004 Cr-Commit-Position: refs/heads/master@{#470142} Committed: https://chromium.googlesource.com/chromium/src/+/3449c607560559da80f7ecc9c3e5b24440b9010c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 1 chunk +21 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
Tom (Use chromium acct)
erg ptal This is copied from https://codereview.chromium.org/2852593002/
3 years, 7 months ago (2017-05-08 18:24:34 UTC) #3
Tom Anderson
TBR'ing erg since he's OOO and the other CL already got approval lgtm from my ...
3 years, 7 months ago (2017-05-08 21:31:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2869763004/1
3 years, 7 months ago (2017-05-08 21:43:10 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 21:55:10 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3449c607560559da80f7ecc9c3e5...

Powered by Google App Engine
This is Rietveld 408576698