Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2869753002: Pass NativeDataBuilder through ResolutionWorldBuilder (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pass NativeDataBuilder through ResolutionWorldBuilder R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/03af677cd349e0c63afeb80aa49a9c3296aa9737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M pkg/compiler/lib/src/frontend_strategy.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 4 chunks +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-08 12:17:52 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-08 22:16:34 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-09 07:56:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03af677cd349e0c63afeb80aa49a9c3296aa9737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698