Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc

Issue 2869733005: Convert some audio code to OnceCallback. (Closed)
Patch Set: Fix BindToCurrentLoop issues Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc
diff --git a/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc b/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc
index d3f0199ae62a9cf9e8fb2564826e67b6353178c2..2a039c460558e72c417316e6c44b61edd8e38a56 100644
--- a/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc
+++ b/content/browser/renderer_host/media/renderer_audio_output_stream_factory_context_impl_unittest.cc
@@ -81,8 +81,8 @@ void SyncWith(scoped_refptr<base::SingleThreadTaskRunner> task_runner) {
CHECK(!task_runner->BelongsToCurrentThread());
base::WaitableEvent e = {base::WaitableEvent::ResetPolicy::MANUAL,
base::WaitableEvent::InitialState::NOT_SIGNALED};
- task_runner->PostTask(FROM_HERE, base::Bind(&base::WaitableEvent::Signal,
- base::Unretained(&e)));
+ task_runner->PostTask(FROM_HERE, base::BindOnce(&base::WaitableEvent::Signal,
+ base::Unretained(&e)));
e.Wait();
}
@@ -345,10 +345,9 @@ TEST_F(RendererAudioOutputStreamFactoryIntegrationTest, StreamIntegrationTest) {
AudioOutputStreamFactoryPtr factory_ptr;
BrowserThread::PostTask(
BrowserThread::IO, FROM_HERE,
- base::Bind(&RendererAudioOutputStreamFactoryIntegrationTest::
- CreateAndBindFactory,
- base::Unretained(this),
- base::Passed(mojo::MakeRequest(&factory_ptr))));
+ base::BindOnce(&RendererAudioOutputStreamFactoryIntegrationTest::
+ CreateAndBindFactory,
+ base::Unretained(this), mojo::MakeRequest(&factory_ptr)));
AudioOutputStreamProviderPtr provider_ptr;
base::RunLoop loop;
@@ -357,9 +356,9 @@ TEST_F(RendererAudioOutputStreamFactoryIntegrationTest, StreamIntegrationTest) {
std::string id;
factory_ptr->RequestDeviceAuthorization(
mojo::MakeRequest(&provider_ptr), kNoSessionId, "default",
- base::Bind(&AuthCallback, base::Passed(loop.QuitWhenIdleClosure()),
- base::Unretained(&status), base::Unretained(&params),
- base::Unretained(&id)));
+ base::BindOnce(&AuthCallback, loop.QuitWhenIdleClosure(),
+ base::Unretained(&status), base::Unretained(&params),
+ base::Unretained(&id)));
loop.Run();
ASSERT_EQ(status, media::OUTPUT_DEVICE_STATUS_OK);
ASSERT_EQ(GetTestAudioParameters().AsHumanReadableString(),

Powered by Google App Engine
This is Rietveld 408576698