Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 2869733005: Convert some audio code to OnceCallback. (Closed)
Patch Set: Rebase, comments on unretained. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc
index 1061e599ce56ee236899472ef5d72775be61715b..f1990be0fa5a3fd5e5fd82d2d1485bb4e8107516 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host.cc
@@ -46,12 +46,12 @@ void UMALogDeviceAuthorizationTime(base::TimeTicks auth_start_time) {
// |callback| on the IO thread with true if the ID is valid.
void ValidateRenderFrameId(int render_process_id,
int render_frame_id,
- const base::Callback<void(bool)>& callback) {
+ base::OnceCallback<void(bool)> callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
const bool frame_exists =
!!RenderFrameHost::FromID(render_process_id, render_frame_id);
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
- base::Bind(callback, frame_exists));
+ base::BindOnce(std::move(callback), frame_exists));
}
} // namespace
@@ -191,9 +191,9 @@ void AudioRendererHost::OnRequestDeviceAuthorization(
// |authorization_handler_| owns the callback.
authorization_handler_.RequestDeviceAuthorization(
render_frame_id, session_id, device_id, security_origin,
- base::Bind(&AudioRendererHost::AuthorizationCompleted,
- base::Unretained(this), stream_id, security_origin,
- auth_start_time));
+ base::BindOnce(&AudioRendererHost::AuthorizationCompleted,
+ base::Unretained(this), stream_id, security_origin,
+ auth_start_time));
}
void AudioRendererHost::AuthorizationCompleted(
@@ -279,10 +279,10 @@ void AudioRendererHost::OnCreateStream(int stream_id,
// force-close the stream later if validation fails.
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
- base::Bind(validate_render_frame_id_function_, render_process_id_,
- render_frame_id,
- base::Bind(&AudioRendererHost::DidValidateRenderFrame, this,
- stream_id)));
+ base::BindOnce(validate_render_frame_id_function_, render_process_id_,
+ render_frame_id,
+ base::BindOnce(&AudioRendererHost::DidValidateRenderFrame,
+ this, stream_id)));
MediaObserver* const media_observer =
GetContentClient()->browser()->GetMediaObserver();

Powered by Google App Engine
This is Rietveld 408576698