Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 286973004: Fix keyboard interrupt in test driver. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix keyboard interrupt in test driver. Drain the queues to prevent failures when queues are garbage collected. Fails when interrupting test262 otherwise. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21334

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/testrunner/local/pool.py View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 7 months ago (2014-05-15 14:56:12 UTC) #1
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-15 14:57:00 UTC) #2
Michael Achenbach
6 years, 7 months ago (2014-05-15 15:01:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21334 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698