Remove dependency of TranslateInfobarDelegate on profile

Remove dependency of TranslateInfobarDelegate on profile

This CL uses TranslateTabHelper instead of Profile and also cleans up
some unused code and irrelevant dependencies.

BUG=371845
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270758

[droger, 2014-05-15 14:05:36]

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.cc:151:
translate_tab_helper->GetTranslateAcceptLanguages();
This is fine because the TranslateAcceptLanguagesFactory internally redirects to
the original profile.

[blundell, 2014-05-15 15:33:47]

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.cc (left):

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.cc:287: base::string16
TranslateInfoBarDelegate::GetLanguageDisplayableName(
This was just dead code?

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.cc:149:
translate_tab_helper->GetPrefs()));
what about this?

[droger, 2014-05-15 15:42:26]

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.cc (left):

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.cc:287: base::string16
TranslateInfoBarDelegate::GetLanguageDisplayableName(
On 2014/05/15 15:33:48, blundell wrote:
> This was just dead code?

yes

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.cc:149:
translate_tab_helper->GetPrefs()));
On 2014/05/15 15:33:48, blundell wrote:
> what about this?

Yes, it works. The implementation of this is:

Profile* profile =
      Profile::FromBrowserContext(web_contents()->GetBrowserContext());
return profile->GetOriginalProfile()->GetPrefs();

[blundell, 2014-05-15 15:45:01]

LGTM

[droger, 2014-05-15 15:48:02]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2014-05-15 15:50:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/droger@chromium.org/286973003/1

[commit-bot: I haz the power, 2014-05-15 16:47:40]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[tfarina, 2014-05-15 17:43:38]

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.cc:1: // Copyright 2012 The
Chromium Authors. All rights reserved.
Leave the (c). I know the new policy is without. But the old one were with (c).

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
File chrome/browser/translate/translate_infobar_delegate.h (right):

https://codereview.chromium.org/286973003/diff/1/chrome/browser/translate/tra...
chrome/browser/translate/translate_infobar_delegate.h:1: // Copyright 2011 The
Chromium Authors. All rights reserved.
I'd not touch old copyright headers.

[commit-bot: I haz the power, 2014-05-15 18:54:50]

Change committed as 270758