src/arm/assembler-arm-inl.h - Issue 2869683004: [arm] Share constant pool entries in snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/assembler-arm-inl.h

Issue 2869683004: [arm] Share constant pool entries in snapshot. (Closed)

Patch Set: Update tools/v8heapconst.py Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/assembler-arm-inl.h

diff --git a/src/arm/assembler-arm-inl.h b/src/arm/assembler-arm-inl.h

index b5a59bb47646946681017cf703e08e1d7fa2209c..b2ab940bd2c01a6e5f4d6384e4261c83439be3df 100644

--- a/src/arm/assembler-arm-inl.h

+++ b/src/arm/assembler-arm-inl.h

@@ -400,11 +400,7 @@ void Assembler::deserialization_set_target_internal_reference_at(

bool Assembler::is_constant_pool_load(Address pc) {

- if (CpuFeatures::IsSupported(ARMv7)) {

- return !Assembler::IsMovW(Memory::int32_at(pc));

- } else {

- return !Assembler::IsMovImmed(Memory::int32_at(pc));

- }

+ return IsLdrPcImmediateOffset(Memory::int32_at(pc));

}