Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 2869653002: add constructor initializer completions (Closed)

Created:
3 years, 7 months ago by danrubel
Modified:
3 years, 7 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -8 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 4 chunks +17 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 7 months ago (2017-05-08 04:14:34 UTC) #2
pquitslund
Nice. Thanks! LGTM.
3 years, 7 months ago (2017-05-08 04:16:30 UTC) #3
danrubel
3 years, 7 months ago (2017-05-08 12:52:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb15a4c7c9da5c5612809dadad913c6f31380947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698