Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: pkg/front_end/lib/incremental_kernel_generator.dart

Issue 2869563002: Initial version of Fasta based IncrementalKernelGenerator. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/incremental_kernel_generator.dart
diff --git a/pkg/front_end/lib/incremental_kernel_generator.dart b/pkg/front_end/lib/incremental_kernel_generator.dart
index 3b3b429df842a2a89499bb1239af76aa1dd8f69b..a1ea76d17c99689269074c39532f8b31bcb0b3da 100644
--- a/pkg/front_end/lib/incremental_kernel_generator.dart
+++ b/pkg/front_end/lib/incremental_kernel_generator.dart
@@ -56,7 +56,7 @@ abstract class IncrementalKernelGenerator {
/// initial set of valid sources is empty. To obtain a kernel representation
/// of the program, call [computeDelta].
factory IncrementalKernelGenerator(Uri source, CompilerOptions options) =>
- new IncrementalKernelGeneratorImpl(source, new ProcessedOptions(options));
+ new IncrementalKernelGeneratorImpl(source, options);
Paul Berry 2017/05/07 14:17:40 Why are you removing ProcessedOptions? Is there s
scheglov 2017/05/07 17:38:49 It seemed to me initially that ProcessedOptions is
/// Generates a kernel representation of the changes to the program, assuming
/// that all valid sources are unchanged since the last call to
@@ -89,6 +89,8 @@ abstract class IncrementalKernelGenerator {
/// Remove any source file(s) associated with the given file path from the set
/// of valid sources. This guarantees that those files will be re-read on the
/// next call to [computeDelta]).
+ ///
+ /// TODO(scheglov) Update to use URI.
void invalidate(String path);
/// Remove all source files from the set of valid sources. This guarantees

Powered by Google App Engine
This is Rietveld 408576698