Roll FFmpeg for M37.

media/cast/test/sender.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Test application that simulates a cast sender - Data can be either generated
 // or read from a file.
 
 #include <queue>
 
 #include "base/at_exit.h"
@@ skipping 122 matching lines @@
   video_config.max_qp = 40;
 
   // SSRCs and payload type. Don't change them.
   video_config.rtp_config.ssrc = 11;
   video_config.incoming_feedback_ssrc = 12;
   video_config.rtp_config.payload_type = 96;
   video_config.rtp_config.max_delay_ms = 300;
   return video_config;
 }
 
-void AVFreeFrame(AVFrame* frame) { avcodec_free_frame(&frame); }
+void AVFreeFrame(AVFrame* frame) { av_frame_free(&frame); }
 
 class SendProcess {
  public:
   SendProcess(scoped_refptr<base::SingleThreadTaskRunner> thread_proxy,
               base::TickClock* clock,
               const VideoSenderConfig& video_config)
       : test_app_thread_proxy_(thread_proxy),
         video_config_(video_config),
         synthetic_count_(0),
         clock_(clock),
@@ skipping 376 matching lines @@
   }
 
   void DecodeAudio(ScopedAVPacket packet) {
     // Audio.
     AVFrame* avframe = av_frame_alloc();
 
     // Shallow copy of the packet.
     AVPacket packet_temp = *packet.get();
 
     do {
       avcodec_get_frame_defaults(avframe);

[wolenetz, 2014/05/16 19:45:58]

Why not replace with av_frame_unref in this method after the AudioBuffer is
created, below?

[DaleCurtis, 2014/05/16 19:54:26]

Hmm, looks like I missed some in the time this CL was created (months ago) and
now. I'll change these.

[DaleCurtis, 2014/05/20 01:13:45]

Done.

       int frame_decoded = 0;
       int result = avcodec_decode_audio4(
           av_audio_context(), avframe, &frame_decoded, &packet_temp);
       CHECK(result >= 0) << "Failed to decode audio.";
       packet_temp.size -= result;
       packet_temp.data += result;
       if (!frame_decoded)
         continue;
 
       int frames_read = avframe->nb_samples;
@@ skipping 20 matching lines @@
                   av_audio_context()->channel_layout,
                   av_audio_context()->channels),
               av_audio_context()->channels,
               av_audio_context()->sample_rate,
               frames_read,
               &avframe->data[0],
               // Note: Not all files have correct values for pkt_pts.
               base::TimeDelta::FromMilliseconds(avframe->pkt_pts));
       audio_algo_.EnqueueBuffer(buffer);
     } while (packet_temp.size > 0);
-    avcodec_free_frame(&avframe);
+    av_frame_free(&avframe);
 
     const int frames_needed_to_scale =
         playback_rate_ * av_audio_context()->sample_rate /
         kAudioPacketsPerSecond;
     while (frames_needed_to_scale <= audio_algo_.frames_buffered()) {
       if (!audio_algo_.FillBuffer(audio_fifo_input_bus_.get(),
                                   audio_fifo_input_bus_->frames())) {
         // Nothing can be scaled. Decode some more.
         return;
       }
@@ skipping 19 matching lines @@
       audio_resampler_->Resample(resampled_bus->frames(),
                                  resampled_bus.get());
       audio_bus_queue_.push(resampled_bus.release());
     }
   }
 
   void DecodeVideo(ScopedAVPacket packet) {
     // Video.
     int got_picture;
     AVFrame* avframe = av_frame_alloc();
     avcodec_get_frame_defaults(avframe);

[wolenetz, 2014/05/16 19:45:58]

nit: Doesn't av_frame_alloc() already do this?

[DaleCurtis, 2014/05/16 19:54:26]

Yeah

     // Tell the decoder to reorder for us.
     avframe->reordered_opaque =
         av_video_context()->reordered_opaque = packet->pts;
     CHECK(avcodec_decode_video2(

[wolenetz, 2014/05/16 19:45:58]

ditto: Why don't we iterate through decoding video packets like we do for audio,
if decode retval >0 and < packet.size (and use a shallow temp_packet,
similarly)?

[DaleCurtis, 2014/05/16 19:54:26]

Ditto.

         av_video_context(), avframe, &got_picture, packet.get()) >= 0)

[wolenetz, 2014/05/16 19:45:58]

ditto: protect against MPEG overreads?

[DaleCurtis, 2014/05/16 19:54:26]

Ditto.

[DaleCurtis, 2014/05/20 01:13:45]

Modulo, that ffmpeg does this automatically for us similar to how DecoderBuffer
does this.

         << "Video decode error.";
     if (!got_picture)
       return;
     gfx::Size size(av_video_context()->width, av_video_context()->height);
     if (!video_first_pts_set_ ||
         avframe->reordered_opaque < video_first_pts_) {
       video_first_pts_set_ = true;
       video_first_pts_ = avframe->reordered_opaque;
     }
     int64 pts = avframe->reordered_opaque - video_first_pts_;
@@ skipping 374 matching lines @@
                  base::Passed(&audio_stats_subscriber),
                  base::Passed(&offset_estimator)),
       base::TimeDelta::FromSeconds(logging_duration_seconds));
 
   send_process->Start(cast_sender->audio_frame_input(),
                       cast_sender->video_frame_input());
 
   io_message_loop.Run();
   return 0;
 }