Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 286953002: Remove GetViewBoundsWithResizeLock. (Closed)

Created:
6 years, 7 months ago by piman
Modified:
6 years, 7 months ago
Reviewers:
danakj
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Remove GetViewBoundsWithResizeLock. Before delegated rendering, it was needed to throttle resizes beyond the existing resize ack mechanism, because we could receive the frame after the ViewHostMsg_UpdateRect with the ack. With delegated rendering, we receive the frame before the ack (ack is sent in RenderWidget::didCompleteSwapBuffers, which necessarily happens after CompositorOutputSurface::SwapBuffers which sends the ViewHostMsg_SwapCompositorFrame) This then avoids RenderWidgetHostViewAura::GetViewBounds from changing based on renderer state, which removes transient states (and related test flakiness). This depends on https://codereview.chromium.org/286053002/ because this exposes test flakiness. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M content/browser/compositor/delegated_frame_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
Prereq for https://codereview.chromium.org/274163004/
6 years, 7 months ago (2014-05-14 23:45:07 UTC) #1
danakj
LGTM
6 years, 7 months ago (2014-05-15 14:27:30 UTC) #2
piman
The CQ bit was checked by piman@chromium.org
6 years, 7 months ago (2014-05-15 16:43:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/286953002/1
6 years, 7 months ago (2014-05-15 16:43:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 17:35:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-15 17:44:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/16800)
6 years, 7 months ago (2014-05-15 17:45:00 UTC) #7
piman
The CQ bit was checked by piman@chromium.org
6 years, 7 months ago (2014-05-15 19:35:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/286953002/1
6 years, 7 months ago (2014-05-15 19:36:52 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 19:49:23 UTC) #10
Message was sent while issue was closed.
Change committed as 270786

Powered by Google App Engine
This is Rietveld 408576698