Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2869483003: Implement GetSystemLog on Linux platform

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Implement GetSystemLog on Linux platform BUG=chromium:715318

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M telemetry/telemetry/core/platform_unittest.py View 1 chunk +5 lines, -0 lines 1 comment Download
M telemetry/telemetry/internal/platform/linux_platform_backend.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
nednguyen
3 years, 7 months ago (2017-05-05 21:02:37 UTC) #2
Ken Russell (switch to Gerrit)
3 years, 7 months ago (2017-05-07 18:56:49 UTC) #9
lgtm

https://codereview.chromium.org/2869483003/diff/1/telemetry/telemetry/core/pl...
File telemetry/telemetry/core/platform_unittest.py (right):

https://codereview.chromium.org/2869483003/diff/1/telemetry/telemetry/core/pl...
telemetry/telemetry/core/platform_unittest.py:48:
@decorators.Disabled('android', 'win')
Is this Disabled attribute sufficient? It looks like GetSystemLog is implemented
only on macOS and Linux (with this CL). What about ChromeOS, for example?

Perhaps explicitly enable this test on the platforms where it's known to pass?

Powered by Google App Engine
This is Rietveld 408576698