Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2509)

Unified Diff: ash/shelf/shelf_model_unittest.cc

Issue 2869473002: Fix crash on openning settings when DCHECK is on. (Closed)
Patch Set: use new id for app list Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_model_unittest.cc
diff --git a/ash/shelf/shelf_model_unittest.cc b/ash/shelf/shelf_model_unittest.cc
index 12177d7dd60336a9eaf00533fd1c24979229194d..1324b11b6f14e769aac31137bfe6d0a4742c684f 100644
--- a/ash/shelf/shelf_model_unittest.cc
+++ b/ash/shelf/shelf_model_unittest.cc
@@ -15,6 +15,8 @@ namespace ash {
namespace {
+constexpr char kAppListId[] = "jlfapfmkapbjlfbpjedlinehodkccjee";
+
// ShelfModelObserver implementation that tracks what message are invoked.
class TestShelfModelObserver : public ShelfModelObserver {
public:
@@ -69,7 +71,7 @@ class ShelfModelTest : public testing::Test {
ShelfItem item;
item.type = TYPE_APP_LIST;
- item.id = ShelfID("AppListId");
+ item.id = ShelfID(kAppListId);
model_->Add(item);
EXPECT_EQ(1, model_->item_count());
« no previous file with comments | « ash/shelf/app_list_shelf_item_delegate.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698