Fix crash on openning settings when DCHECK is on.

ash/shelf/app_list_shelf_item_delegate.cc

Index: ash/shelf/app_list_shelf_item_delegate.cc
diff --git a/ash/shelf/app_list_shelf_item_delegate.cc b/ash/shelf/app_list_shelf_item_delegate.cc
index 559c2dd6431442bfc0133fc386d2a9ee0fb543fb..dd9fbd7aec110986c0054dff70a93f104d2a4fa4 100644
--- a/ash/shelf/app_list_shelf_item_delegate.cc
+++ b/ash/shelf/app_list_shelf_item_delegate.cc
@@ -13,12 +13,9 @@
 
 namespace ash {
 
-namespace {
-
-// An app id for the app list, used to identify the shelf item.
-static constexpr char kAppListId[] = "AppListId";
-
-}  // namespace
+// static
+const char AppListShelfItemDelegate::kAppListId[] =
+    "eiiblffaiacobmjejhcoookmokblahea";

[msw, 2017/05/05 21:45:04]

Instead of using an arc-specific formatting for the input via
ArcAppListPrefs::GetAppId("chrome.settings", "chrome.settings.ui"), could you
use crx_file::id_util::GenerateId("org.chromium.settings_ui") or similar for
this and the other new ids, and document what you used in comments with the
generated id literals?

[khmel, 2017/05/05 22:45:12]

That makes sense.

 
 // static
 void AppListShelfItemDelegate::CreateAppListItemAndDelegate(ShelfModel* model) {