pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart - Issue 2869463002: Better stack trace support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

Issue 2869463002: Better stack trace support (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

index dfaa87289a5dfd7627c916505da391177ec4472b..03ff5a095a84a77496973b7f0dbbfec613d6a86c 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/errors.dart

@@ -88,6 +88,11 @@ throwAssertionError([message]) => JS(

$throw_(error);

})()''');

+throwCyclicInitializationError([String message]) {

+ if (_trapRuntimeErrors) JS('', 'debugger');

+ throw new CyclicInitializationError(message);

throwNullValueError() => JS(

'',

'''(() => {