Reducing CPU cycles of hidden/minimized browser windows

content/browser/web_contents/web_contents_view_aura.h

Index: content/browser/web_contents/web_contents_view_aura.h
diff --git a/content/browser/web_contents/web_contents_view_aura.h b/content/browser/web_contents/web_contents_view_aura.h
index 9cf4182ea9f68b4452b5bf42572aee4aa17f3260..8b9004d18bf46678871f64a8ad27b2e63fe826f0 100644
--- a/content/browser/web_contents/web_contents_view_aura.h
+++ b/content/browser/web_contents/web_contents_view_aura.h
@@ -14,6 +14,7 @@
 #include "content/browser/web_contents/web_contents_view.h"
 #include "content/common/content_export.h"
 #include "ui/aura/window_delegate.h"
+#include "ui/aura/window_observer.h"
 #include "ui/compositor/layer_animation_observer.h"
 #include "ui/wm/public/drag_drop_delegate.h"
 
@@ -41,7 +42,8 @@ class WebContentsViewAura
       public OverscrollControllerDelegate,
       public ui::ImplicitAnimationObserver,
       public aura::WindowDelegate,
-      public aura::client::DragDropDelegate {
+      public aura::client::DragDropDelegate,
+      public aura::WindowObserver {

[ncarter (slow), 2014/05/20 21:40:01]

Why not extend the existing WebContentsViewAura::WindowObserver /
window_observer_ helper ? It seems inconsistent for this class to be observing
window_ both directly and via a helper.

[Mr4D (OOO till 08-26), 2014/05/20 21:48:56]

The existing observer is heavily Windows dependent and has many more functions
(like that several window observers get set). Last but not least it is mentioned
that most of that observer was meant for constrained windows and NPAPI (which
will go away soon).

That all said - if you want it to be in there I will add it there as well.

  public:
   WebContentsViewAura(WebContentsImpl* web_contents,
                       WebContentsViewDelegate* delegate);
@@ -176,6 +178,12 @@ class WebContentsViewAura
   virtual void OnDragExited() OVERRIDE;
   virtual int OnPerformDrop(const ui::DropTargetEvent& event) OVERRIDE;
 
+  // Overridden from aura::WindowObserver:
+  virtual void OnWindowParentChanged(aura::Window* window,
+                                     aura::Window* parent) OVERRIDE;
+  virtual void OnWindowVisibilityChanged(aura::Window* window,
+                                         bool visible) OVERRIDE;
+
   scoped_ptr<aura::Window> window_;
 
   // The window that shows the screenshot of the history page during an