Reducing CPU cycles of hidden/minimized browser windows

content/browser/web_contents/web_contents_view_aura_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_view_aura.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_timeouts.h"
@@ skipping 576 matching lines @@
   aura::test::EventGenerator generator(content->GetRootWindow(), content);
   generator.GestureScrollSequence(
       gfx::Point(bounds.x() + 2, bounds.y() + 10),
       gfx::Point(bounds.right() - 10, bounds.y() + 10),
       base::TimeDelta::FromMilliseconds(20),
       1);
 
   window->AddChild(shell()->web_contents()->GetContentNativeView());
 }
 
-IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,
-                       ContentWindowClose) {
+IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, ContentWindowClose) {
   ASSERT_NO_FATAL_FAILURE(
       StartTestWithPage("files/overscroll_navigation.html"));
 
   WebContentsImpl* web_contents =
       static_cast<WebContentsImpl*>(shell()->web_contents());
   ExecuteSyncJSFunction(web_contents->GetMainFrame(), "navigate_next()");
   EXPECT_EQ(1, GetCurrentIndex());
 
   aura::Window* content = web_contents->GetContentNativeView();
   gfx::Rect bounds = content->GetBoundsInRootWindow();
@@ skipping 68 matching lines @@
       base::TimeDelta::FromMilliseconds(2000),
       10);
   base::string16 actual_title = title_watcher.WaitAndGetTitle();
   EXPECT_EQ(expected_title, actual_title);
 
   EXPECT_EQ(2, GetCurrentIndex());
   EXPECT_TRUE(controller.CanGoBack());
   EXPECT_FALSE(controller.CanGoForward());
 }
 
+// Verify that hiding a parent of the renderer will hide the content too.
+IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, HideContentOnParenHide) {
+  ASSERT_NO_FATAL_FAILURE(StartTestWithPage("files/title1.html"));
+  WebContentsImpl* web_contents =
+      static_cast<WebContentsImpl*>(shell()->web_contents());
+  aura::Window* content = web_contents->GetContentNativeView();

[sky, 2014/05/20 23:33:51]

I'm surprised this works. web_contents->GetContentNativeView returns a
descendant of the window, not an ancestor. You want an ancestor.

[Mr4D (OOO till 08-26), 2014/05/21 14:25:03]

I am not using this window - I am using it's parent. For the sake of argument I
should however even be able to go higher. Done.

+  aura::Window* parent = content->parent();
+  EXPECT_TRUE(web_contents->should_normally_be_visible());
+  parent->Hide();

[ncarter (slow), 2014/05/20 21:42:26]

Does this actually minimize the parent? Wasn't the original bug that Hide() was
never being called on the parent?

[Mr4D (OOO till 08-26), 2014/05/20 21:48:56]

Well - If I understand sky's request correctly, we have a test that a minimize
triggers a hide. As such only a test is required which proofs that the hide
triggers a content hide as well.

[sky, 2014/05/20 23:33:51]

Exactly.

+  EXPECT_FALSE(web_contents->should_normally_be_visible());
+  parent->Show();
+  EXPECT_TRUE(web_contents->should_normally_be_visible());
+}
+
 }  // namespace content