content/browser/frame_host/render_frame_host_impl.h - Issue 2869423002: PlzNavigate: Do not disclose urls between cross-origin renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2869423002: PlzNavigate: Do not disclose urls between cross-origin renderers. (Closed)

Patch Set: Applying suggestions. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 748567856514dce3ac0c095a1403bfc4af6b2f7d..97950900c7a76ddcd16f793ba95a2aef5fe5d339 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -218,6 +218,11 @@ class CONTENT_EXPORT RenderFrameHostImpl

void ReportContentSecurityPolicyViolation(

const CSPViolationParams& violation_params) override;

bool SchemeShouldBypassCSP(const base::StringPiece& scheme) override;

+ void SanitizeDataForUseInCspViolation(

+ GURL* blocked_url,

alexmos 2017/05/16 05:56:49 nit: reorder params so that inputs come before out

arthursonzogni 2017/05/16 12:48:44 Done.

+ SourceLocation* source_location,

+ bool is_redirect,

+ CSPDirective::Name directive) const override;

// Creates a RenderFrame in the renderer process.

bool CreateRenderFrame(int proxy_routing_id,