Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2869403002: Move ElementEnvironment.isSubtype to DartTypes (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/frontend_strategy.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 5 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-10 13:37:19 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-10 17:57:15 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-12 08:10:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf779d8d07ff6e12c9d8cfe32c3be1790586b9d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698