Allow overriding core types in dart:_interceptors.

Allow overriding core types in dart:_interceptors.

This gets rid of the warning you get today when building the SDK (you can see
this on the `build.py -m release patched_dart2js_sdk` target).

R=ahe@google.com, paulberry@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/bd85c499b04ccd66dc3b3dc12e5435862e56a675

[Siggi Cherem (dart-lang), 2017-05-10 18:14:22]

https://codereview.chromium.org/2869393003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2869393003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_loader.dart:398: // dart:_interceptors
(for dart2js).
not sure that it is worth saying in the TODO: I dont' do so to keep fasta
agnostic of the platform it is used for.

[Paul Berry, 2017-05-10 18:19:18]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[Paul Berry, 2017-05-10 18:19:18]

lgtm but I'm not too familiar with this code.

+Konstantin in case he is more qualified to review.

[scheglov, 2017-05-10 18:27:47]

LGTM

https://codereview.chromium.org/2869393003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2869393003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/source_loader.dart:398: // dart:_interceptors
(for dart2js).
On 2017/05/10 18:14:22, Siggi Cherem (dart-lang) wrote:
> not sure that it is worth saying in the TODO: I dont' do so to keep fasta
> agnostic of the platform it is used for.

FWIW, in analyzer we use similar check - we allow extending special classes
(bool, num, int, double, String) in any "system library", which mean "dart"
scheme. We have a comment about this, but not TODO, because WAI.

  bool _checkForExtendsOrImplementsDisallowedClass(
      TypeName typeName, ErrorCode errorCode) {
    if (typeName.isSynthetic) {
      return false;
    }
    // The SDK implementation may implement disallowed types. For example,
    // JSNumber in dart2js and _Smi in Dart VM both implement int.
    if (_currentLibrary.source.isInSystemLibrary) {
      return false;
    }

[Siggi Cherem (dart-lang), 2017-05-10 18:32:50]

Thanks! - updated from TODO to a simple comment.

[Siggi Cherem (dart-lang), 2017-05-10 18:33:29]

Description was changed from

==========
Allow overriding core types in dart:_interceptors.

This gets rid of the warning you get today when building the SDK (you can see
this on the `build.py -m release patched_dart2js_sdk` target).

R=paulberry@google.com,ahe@google.com
==========

to

==========
Allow overriding core types in dart:_interceptors.

This gets rid of the warning you get today when building the SDK (you can see
this on the `build.py -m release patched_dart2js_sdk` target).

R=ahe@google.com, paulberry@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bd85c499b04ccd66dc3b3dc12e5435862e56a675
==========

[Siggi Cherem (dart-lang), 2017-05-10 18:33:30]

Committed patchset #2 (id:20001) manually as
bd85c499b04ccd66dc3b3dc12e5435862e56a675 (presubmit successful).

[ahe, 2017-05-29 15:49:55]

https://codereview.chromium.org/2869393003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2869393003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/source_loader.dart:394: } else if
(!cls.library.uri.isScheme('dart') &&
I'm concerned about performance of this change. This loops over all classes and
performs string manipulation on URIs.

In addition, would prefer if this invariant was broken by dart2js specific code.

[Siggi Cherem (dart-lang), 2017-05-30 19:22:02]

https://codereview.chromium.org/2869393003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2869393003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/source_loader.dart:394: } else if
(!cls.library.uri.isScheme('dart') &&
On 2017/05/29 15:49:55, ahe wrote:
> I'm concerned about performance of this change. This loops over all classes
and
> performs string manipulation on URIs.
> 
> In addition, would prefer if this invariant was broken by dart2js specific
code.

Good point - I'll take a stab at making this overridable by dart2js instead.

[Siggi Cherem (dart-lang), 2017-05-30 21:16:58]

https://codereview.chromium.org/2869393003/diff/20001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/source/source_loader.dart (right):

https://codereview.chromium.org/2869393003/diff/20001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/source/source_loader.dart:394: } else if
(!cls.library.uri.isScheme('dart') &&
On 2017/05/30 19:22:01, Siggi Cherem (dart-lang) wrote:
> On 2017/05/29 15:49:55, ahe wrote:
> > I'm concerned about performance of this change. This loops over all classes
> and
> > performs string manipulation on URIs.
> > 
> > In addition, would prefer if this invariant was broken by dart2js specific
> code.
> 
> Good point - I'll take a stab at making this overridable by dart2js instead.

Sent you https://codereview.chromium.org/2907333003/ to address this.