Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: components/safe_browsing_db/BUILD.gn

Issue 2869383002: Unify safe_browsing* components [1]: move safe_browsing_prefs* (Closed)
Patch Set: fix win bots Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/common/safe_browsing_prefs_unittest.cc ('k') | components/safe_browsing_db/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing_db/BUILD.gn
diff --git a/components/safe_browsing_db/BUILD.gn b/components/safe_browsing_db/BUILD.gn
index 68a841c69e00b166bd90195e16241266dfb60c45..fb9286f8e4c5bdf52abad5a16259b49dbc1b7a09 100644
--- a/components/safe_browsing_db/BUILD.gn
+++ b/components/safe_browsing_db/BUILD.gn
@@ -31,9 +31,9 @@ group("safe_browsing_db_shared") {
":database_manager",
":hit_report",
":prefix_set",
- ":safe_browsing_prefs",
":safebrowsing_proto",
":util",
+ "//components/safe_browsing/common:safe_browsing_prefs",
]
}
@@ -82,8 +82,8 @@ static_library("hit_report") {
":util",
]
deps = [
- ":safe_browsing_prefs",
"//components/metrics",
+ "//components/safe_browsing/common:safe_browsing_prefs",
"//url",
]
}
@@ -152,17 +152,6 @@ static_library("safe_browsing_api_handler_util") {
]
}
-static_library("safe_browsing_prefs") {
- sources = [
- "safe_browsing_prefs.cc",
- "safe_browsing_prefs.h",
- ]
- deps = [
- "//base:base",
- "//components/prefs",
- ]
-}
-
static_library("test_database_manager") {
sources = [
"test_database_manager.cc",
@@ -181,8 +170,8 @@ static_library("util") {
"util.h",
]
public_deps = [
- ":safe_browsing_prefs",
":v4_protocol_manager_util",
+ "//components/safe_browsing/common:safe_browsing_prefs",
]
deps = [
"//base",
@@ -325,12 +314,12 @@ static_library("v4_update_protocol_manager") {
"v4_update_protocol_manager.h",
]
deps = [
- ":safe_browsing_prefs",
":safebrowsing_proto",
":util",
":v4_protocol_manager_util",
"//base",
"//components/data_use_measurement/core",
+ "//components/safe_browsing/common:safe_browsing_prefs",
"//net",
"//url",
]
@@ -413,7 +402,6 @@ source_set("unit_tests") {
sources = [
"database_manager_unittest.cc",
"prefix_set_unittest.cc",
- "safe_browsing_prefs_unittest.cc",
"util_unittest.cc",
"v4_database_unittest.cc",
"v4_get_hash_protocol_manager_unittest.cc",
@@ -426,7 +414,6 @@ source_set("unit_tests") {
deps = [
":database_manager",
":prefix_set",
- ":safe_browsing_prefs",
":safebrowsing_proto",
":test_database_manager",
":util",
@@ -441,6 +428,7 @@ source_set("unit_tests") {
":v4_update_protocol_manager",
"//base",
"//components/prefs:test_support",
+ "//components/safe_browsing/common:safe_browsing_prefs",
"//content/test:test_support",
"//crypto",
"//net",
« no previous file with comments | « components/safe_browsing/common/safe_browsing_prefs_unittest.cc ('k') | components/safe_browsing_db/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698