Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(433)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: components/safe_browsing/common/DEPS
Issue
2869383002
:
Unify safe_browsing* components [1]: move safe_browsing_prefs* (Closed)
Patch Set: fix win bots
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/browser/android/preferences/pref_service_bridge.cc
chrome/browser/chrome_content_browser_client.cc
chrome/browser/download/download_browsertest.cc
chrome/browser/extensions/BUILD.gn
chrome/browser/extensions/api/preference/preference_api.cc
chrome/browser/extensions/api/settings_private/prefs_util.cc
chrome/browser/interstitials/chrome_controller_client.cc
chrome/browser/profiles/profile.cc
chrome/browser/safe_browsing/certificate_reporting_service.cc
chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc
chrome/browser/safe_browsing/chrome_password_protection_service.cc
chrome/browser/safe_browsing/client_side_detection_host.cc
chrome/browser/safe_browsing/client_side_detection_service.cc
chrome/browser/safe_browsing/download_protection_service.cc
chrome/browser/safe_browsing/download_protection_service_unittest.cc
chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
chrome/browser/safe_browsing/local_database_manager.h
chrome/browser/safe_browsing/local_database_manager.cc
chrome/browser/safe_browsing/notification_image_reporter.cc
chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
chrome/browser/safe_browsing/protocol_manager.h
chrome/browser/safe_browsing/protocol_manager_unittest.cc
chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
chrome/browser/safe_browsing/safe_browsing_service.h
chrome/browser/safe_browsing/ui_manager.cc
chrome/browser/safe_browsing/ui_manager_unittest.cc
chrome/browser/ssl/bad_clock_blocking_page.cc
chrome/browser/ssl/captive_portal_blocking_page.cc
chrome/browser/ssl/cert_report_helper.cc
chrome/browser/ssl/certificate_reporting_test_utils.cc
chrome/browser/ssl/ssl_blocking_page.cc
chrome/browser/ui/BUILD.gn
chrome/browser/ui/views/download/download_feedback_dialog_view.cc
chrome/browser/ui/views/download/download_item_view.cc
chrome/browser/ui/webui/options/browser_options_handler.cc
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
chrome/browser/ui/webui/settings/safe_browsing_handler.cc
components/BUILD.gn
components/safe_browsing/BUILD.gn
components/safe_browsing/base_blocking_page.cc
components/safe_browsing/common/BUILD.gn
components/safe_browsing/common/DEPS
components/safe_browsing/common/safe_browsing_prefs.h
components/safe_browsing/common/safe_browsing_prefs.cc
components/safe_browsing/common/safe_browsing_prefs_unittest.cc
components/safe_browsing_db/BUILD.gn
components/safe_browsing_db/DEPS
components/safe_browsing_db/hit_report.h
components/safe_browsing_db/safe_browsing_prefs.h
components/safe_browsing_db/safe_browsing_prefs.cc
components/safe_browsing_db/safe_browsing_prefs_unittest.cc
components/safe_browsing_db/util.h
components/safe_browsing_db/v4_update_protocol_manager.h
components/security_interstitials/content/BUILD.gn
components/security_interstitials/content/DEPS
components/security_interstitials/content/security_interstitial_controller_client.cc
components/security_interstitials/content/security_interstitial_page.cc
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« components/safe_browsing/common/BUILD.gn
('k') |
components/safe_browsing/common/safe_browsing_prefs.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: components/safe_browsing/common/DEPS
diff --git a/components/safe_browsing/common/DEPS b/components/safe_browsing/common/DEPS
index acf92ab14c9c7a8634c2574ba0b953ff69d7dd90..61eff4271b89fd4f10508b368060a6d5f01a5cfe 100644
--- a/components/safe_browsing/common/DEPS
+++ b/components/safe_browsing/common/DEPS
@@ -1,4 +1,5 @@
include_rules = [
+ "+components/prefs",
"+ipc",
"+url"
]
« no previous file with comments
|
« components/safe_browsing/common/BUILD.gn
('k') |
components/safe_browsing/common/safe_browsing_prefs.h »
('j') |
no next file with comments »
Issue 2869383002: Unify safe_browsing* components [1]: move safe_browsing_prefs* (Closed)
Created 3 years, 7 months ago by timvolodine
Modified 3 years, 7 months ago
Reviewers: Jialiu Lin, lpz, vakh (use Gerrit instead), jam, blundell
Base URL:
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 2869383002:
Unify safe_browsing* components [1]: move safe_browsing_prefs* (Closed)
